Repository navigation
ci: Remove GameAssembly link outputs before saving the Windows Library cache - #2896
Open
bitsandfoxes wants to merge 2 commits into
Open
bitsandfoxes wants to merge 2 commits into
bitsandfoxes wants to merge 2 commits into
Conversation
bitsandfoxes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows IL2CPP integration builds restore a cached
samples/IntegrationTest/Library/that still holds Bee'sGameAssembly.pdband.ilk. MSVC links incrementally against them, keeping the PDB GUID and only bumping the age, so every branch's build uploadsGameAssemblyunder the same debug IDs (e.g.e78f23f1-…-bande78f23f1-…-con bothmainand#2889). Sentry then symbolicates with whichever build uploaded last, and the IL2CPP line-number assertion fails with frames resolved to the wrong file and line (seen on#2889, where main's upload landed after the PR's).Deleting the
GameAssembly.dll,.pdb, and.ilkonmainbefore saving the Library cache forces a fresh link with a new GUID on every restore while keeping the cached object files.🤖 Generated with Claude Code