test(e2e): Port the TanStack Start React E2E app to span streaming - #24172
Open
RulaKhaled wants to merge 2 commits into
Open
test(e2e): Port the TanStack Start React E2E app to span streaming#24172RulaKhaled wants to merge 2 commits into
RulaKhaled wants to merge 2 commits into
Conversation
Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
Contributor
size-limit report 📦
|
…st leak Co-Authored-By: Cursor Grok 4.6 <cursoragent@cursor.com>
RulaKhaled
marked this pull request as ready for review
September 8, 2026 12:15
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9979f3f. Configure here.
| // at startup and never emit this span. | ||
| if (tunnelRouteMode === 'custom') { | ||
| await waitForServerHttpSpan(pathnameMatchesTunnelRoute); | ||
| } |
There was a problem hiding this comment.
Flaky leftover tunnel span wait
Medium Severity
The custom-route leftover wait starts after the previous test already posted to the tunnel, but waitForStreamedSpan only sees envelopes that arrive after that call. The first leaked span is often already buffered, so this wait can hang until timeout. Flagged because the review rules call out waiting for telemetry after the action that produced it.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 9979f3f. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes span streaming the only path in the TanStack Start React E2E app. The
E2E_TEST_STREAMED_SPANSternary is gone, and the specs wait on streamed spans instead of transaction envelopes.Why
Unparameterized
http.servernames fall back to the method only, so those waits matchurl.path(andhttp.routeonce a route is known). Redis handshake commands and mysql query-summary names (SELECT) are told apart withdb.query.text. Thetunnel-streamedvariant is dropped because it is now identical totunnel-generated. Static-lifecycle coverage moves totanstackstart-react-static.Part of #23805