test(e2e): Migrate Effect to span streaming - #24161
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
Co-Authored-By: GPT-6 <codex@openai.com>
msonnb
force-pushed
the
ms/effect-span-streaming
branch
from
September 7, 2026 13:17
de04922 to
53d4981
Compare
msonnb
marked this pull request as ready for review
September 8, 2026 07:31
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 53d4981. Configure here.
| const spanPromise = waitForStreamedSpan( | ||
| 'effect-3-node', | ||
| span => | ||
| span.is_segment && getSpanOp(span) === 'http.server' && span.attributes['url.path']?.value === `/${route}`, |
There was a problem hiding this comment.
HTTP wait uses missing attribute
High Severity
The HTTP segment wait matches on url.path, but Effect HTTP spans from SentryEffectTracer never set that attribute, and effectLayer disables Node default integrations. The predicate never matches, so these tests time out.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 53d4981. Configure here.
Member
Author
There was a problem hiding this comment.
incorrect, it's set by effect
andreiborza
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exercise Effect 3 and 4 with span streaming, preserving manual and nested span coverage.
part of #23800