test(e2e): Migrate Express 5 and MCP to span streaming - #24157
Merged
Conversation
Contributor
size-limit report 📦
|
Co-Authored-By: GPT-6 <codex@openai.com>
msonnb
force-pushed
the
ms/express-5-mcp-span-streaming
branch
from
September 7, 2026 13:17
551379e to
ab67b74
Compare
msonnb
marked this pull request as ready for review
September 7, 2026 13:31
msonnb
requested review from
a team,
andreiborza,
logaretm and
stephanie-anderson
and removed request for
a team and
stephanie-anderson
September 7, 2026 13:31
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ab67b74. Configure here.
| const initializeSegmentPromise = waitForStreamedSpan( | ||
| 'node-express-v5', | ||
| segment => segment.is_segment && segment.name === 'initialize', | ||
| ); |
There was a problem hiding this comment.
SSE MCP streamed spans will time out
High Severity
The Express 5 MCP suite now waits for streamed handler segments over SSE. The sibling streaming app still skips that path because those MCP spans never arrive in the envelope, so this wait times out instead of recording initialize or later tool, resource, and prompt segments.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit ab67b74. Configure here.
Member
Author
There was a problem hiding this comment.
hmm, they reliably pass both locally and on CI, so i think this is a false positive
andreiborza
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exercise Express 5 and MCP v2 instrumentation with span streaming, including low-cardinality span names and database query attributes.
part of #23800