fix(server-utils): Pass the SQL dialect when summarizing Prisma queries - #23854
Merged
Conversation
Contributor
size-limit report 📦
|
Lms24
marked this pull request as ready for review
September 1, 2026 16:40
Lms24
requested review from
JPeer264 and
isaacs
and removed request for
a team
September 1, 2026 16:40
Lms24
force-pushed
the
lms/fix-prisma-sql-dialect-and-qualified-table-names
branch
2 times, most recently
from
September 2, 2026 07:28
4860c0d to
22dcddf
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Base automatically changed from
lms/feat-server-utils-low-card-db-span-names3
to
develop
September 2, 2026 12:52
Lms24
force-pushed
the
lms/fix-prisma-sql-dialect-and-qualified-table-names
branch
2 times, most recently
from
September 2, 2026 12:58
5ca67c0 to
b29a245
Compare
Lms24
changed the base branch from
develop
to
lms/fix-core-qualified-table-names-in-query-summary
September 2, 2026 12:58
Lms24
force-pushed
the
lms/fix-prisma-sql-dialect-and-qualified-table-names
branch
from
September 3, 2026 07:26
b29a245 to
517a6b5
Compare
Contributor
andreiborza
approved these changes
Sep 7, 2026
nicohrubec
approved these changes
Sep 7, 2026
Prisma is multi-connector but sanitized every statement as standard SQL. On MySQL and MariaDB a `"..."` run is a string literal rather than a quoted identifier, so it survived sanitization; a literal containing `FROM` or `JOIN` then read as a table name and landed in `db.query.summary` — and, with span streaming, in the span name. Derive the dialect from the `db.system.name` / `db.system` Prisma reports, matching what knex already does. Refs #23676 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Lms24
force-pushed
the
lms/fix-prisma-sql-dialect-and-qualified-table-names
branch
from
September 8, 2026 12:06
517a6b5 to
5f1672b
Compare
Lms24
deleted the
lms/fix-prisma-sql-dialect-and-qualified-table-names
branch
September 8, 2026 13:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prisma talks to Postgres, MySQL, SQLite and others, but sanitized every statement as standard SQL. In MySQL,
"..."is a string literal, not a quoted identifier, so the value was never replaced with?. If it containedFROMorJOIN, the summary parser then read it as a table name, which landed in the span name when span streaming is enabled.A MySQL query with an inlined value:
SELECT * FROM User WHERE bio = "x FROM secret_table"SELECT * FROM User WHERE bio = "x FROM secret_table"SELECT * FROM User WHERE bio = ?db.query.summarySELECT User secret_tableSELECT UserRefs #23676