Repository navigation
Conversation
This was referenced Oct 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ci/run-device-integration-tests-in-own-jobs #5811 +/- ##
============================================================================
Coverage 76.13% 76.13%
============================================================================
Files 528 528
Lines 19579 19579
Branches 3829 3829
============================================================================
Hits 14906 14906
Misses 3791 3791
Partials 882 882 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The Unsupported AOT jobs waited for the whole build matrix to use the macOS packages, but any leg's packages work. Every leg already packs and runs aot.Tests.ps1 against its own. linux-arm now runs in the linux-arm64 leg and win-x86 in the win-x64 leg, which removes two jobs and the tail after the matrix. Some arm64 hosts can't run 32-bit ARM binaries and failed with "Exec format error", so QEMU runs them on every host. Its binfmt_misc handler comes before the kernel's own loader, so it runs them even on hosts that could. On the first runs a small uname program confirmed that: it reported armv7l, which only QEMU does, on a host that runs 32-bit ARM natively. The leg now only checks that the handler is enabled. The action runs the tonistiigi/binfmt image privileged, so that image is pinned by digest here and in alpine.yml, like the action itself. On its first run, the AOT and container cases passed under QEMU in 38 seconds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ric-oliv
force-pushed
the
ci/test-unsupported-aot-in-build-legs
branch
from
October 25, 2026 16:22
1f30f05 to
a807d74
Compare
ric-oliv
force-pushed
the
ci/run-device-integration-tests-in-own-jobs
branch
from
October 25, 2026 16:22
2a0f2f4 to
1634a0f
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 5 of 6 for #5806, based on #5810. The two Unsupported AOT jobs check that Sentry turns SentryNative off on runtimes without a native SDK, linux-arm and win-x86. They waited for the whole build matrix to test the macOS packages, and then added their own minutes after it. Any leg's packages work, though, and every leg already packs its own. So linux-arm now runs in the linux-arm64 leg and win-x86 in the win-x64 leg, and the two jobs are gone.
The linux-arm job was also flaky. 4 of 57 attempts failed, and the one log left showed "Exec format error", because some arm64 hosts can't run 32-bit ARM binaries.
docker/setup-qemu-action, pinned as inalpine.yml.unameprogram confirmed that, reportingarmv7lon such a host.This adds one dependency:
setup-qemu-actionpullstonistiigi/binfmtfrom Docker Hub on every linux-arm64 run, asalpine.ymlalready does. If Docker Hub is down, that leg fails at that step. The action runs that image privileged, so it's pinned by digest, here and inalpine.yml, the way the action itself is pinned.In #5791 the tail after the matrix was gone. On linux-arm64 the new steps took about a minute, and the AOT and container cases passed under QEMU.
On this PR's own CI
3 runs. On linux-arm64 the four new steps took 1.0 minute each time, 0.6 of it the linux-arm AOT case, and the handler check passed every time. On win-x64 the win-x86 case took 0.5 to 0.8. No job waits for every leg anymore. On
main, the two AOT jobs ran 1.7 minutes past the last leg. The whole stack's numbers are in #5806.#skip-changelog