fix(timeline): copy anchored modifiers onto a duplicated clip

[EtienneLescot]

Summary

A clip duplicated with Ctrl+C / Ctrl+V lost the modifiers anchored to the original: duplicateClip copied only its trims.

• Zooms, speed regions, annotations and Full Camera regions are now copied through mapAllRegionCollections, so every anchored collection is covered, including later ones. Each copy gets a new id and the copy's clipId.
• Imported audio is not copied, on purpose: a take is media on its own lane, and the track merging behind [Bug]: Reordering clips rewrites imported audio tracks (bed stretched over another clip, loop pushed past the end) #1011 has no safe place for a copied fragment. A test pins this.

Related issue

Closes #1007

Type of change

• Bug fix

Release impact

• Patch

Desktop impact

• Not platform-specific

Testing

• timeline.test.ts: one of each modifier on the copy, 10 s later, with new ids; the original unchanged; a second paste gives three; the input not mutated; an audio take stays on the original.
• 14 files and 435 tests in src/lib/ai-edition/document and the store; both tsc configs; Biome.
• Not done: Ctrl+C / Ctrl+V in the app.

🤖 Generated with Claude Code

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 64b1dbdf-1082-455c-b17e-e7ec04e12cd0

📥 Commits

Reviewing files that changed from the base of the PR and between 8f3046c and ff5ff11.

📒 Files selected for processing (2)

• src/lib/ai-edition/document/timeline.test.ts
• src/lib/ai-edition/document/timeline.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 3 remain after this review.

---

📝 Walkthrough

Walkthrough

duplicateClip now copies anchored non-audio modifiers to the duplicate with fresh IDs and the duplicate’s clip ID. Regression tests cover modifier timing, repeated duplication, and the exclusion of imported audio takes.

Changes

Clip duplication

Layer / File(s)	Summary
Copy anchored modifiers during duplication src/lib/ai-edition/document/timeline.ts, src/lib/ai-edition/document/timeline.test.ts	duplicateClip copies fully clip-anchored regions into non-audio collections and uses the updated document when changing clips and trims. Tests check copied modifiers, shifted times, fresh IDs, repeated duplication, and unchanged imported audio takes.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: my-denia

Merge Risk: ⚪ Minimal · up to ff5ff

The modifier-copying change is mergeable after normal checks. Duplicating a clip still does not duplicate its imported audio take.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description covers the summary, issue, change type, release impact, desktop impact, and testing. However, it says “Closes #1007” even though the linked issue also requests copying audio fragments,…	Change “Closes #1007” to “Refs #1007” or another non-closing reference, unless the issue is updated to reflect that audio fragments are out of scope. Add the Screenshots / video section or state that it is not applicable.
Linked Issues check	⚠️ Warning	Issue [#1007] requires a duplicate to carry anchored modifiers, including audio fragments, with new IDs and the duplicate clipId. duplicateClip copies anchored non-audio region collections through `…	Implement copying of audio fragments anchored to the duplicated clip with new IDs and the duplicate clipId, and add a regression test that checks the copied fragment and preserves the original.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: copying anchored modifiers when duplicating a clip.
Out of Scope Changes check	✅ Passed	The code and tests change only duplicateClip behavior for anchored collections, which directly supports issue [#1007]. The audio exclusion and its test address the same duplication behavior; they ar…
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.

Full details: Description check

Explanation

The description covers the summary, issue, change type, release impact, desktop impact, and testing. However, it says “Closes #1007” even though the linked issue also requests copying audio fragments, which this pull request explicitly excludes.

Full details: Linked Issues check

Explanation

Issue [#1007] requires a duplicate to carry anchored modifiers, including audio fragments, with new IDs and the duplicate clipId. duplicateClip copies anchored non-audio region collections through mapAllRegionCollections and adds tests for zooms, annotations, speed regions, and Full Camera regions. It skips the audio collection, and the added audio test confirms that the take remains only on the original. This leaves the audio-fragment requirement unmet.

• Fix all pre-merge checks with AI

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}