Skip to content

[Bug]: The chat panel's reasoning menu and model quick-pick ignore Esc #1039

Description

@EtienneLescot

What happens

In the AI chat panel:

  • the reasoning effort menu (the chip beside the model) closes neither on Esc nor on a click outside. Only picking an effort, or clicking the chip again, closes it;
  • the model quick-pick closes on a click outside and on its close button, but not on Esc.

Same family as #1015.

Cause

Both are hand-rolled portals in src/components/ai-edition/LeftPanel.tsx: the reasoning menu (around line 1503) and ModelQuickPopover (around line 128). Neither handles a keydown, and the reasoning menu has no outside-click handling either.

Expected

Esc closes either one and gives focus back to its button, and a click outside closes the reasoning menu. The shared Popover (Radix) gives both, as #1036 does for the Edit clip menu.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions