Repository navigation
bandit: add bandit.selected_tracks key - #29
Merged
Merged
Conversation
Track name of each selected arm, index-aligned with bandit.selected_arms, so the bandit select span can be queried by track without joining arm IDs (r<region>:t<track>) against the track table. Part of getlantern/engineering#3702. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Comment |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The key follows established naming, typing, grouping, and documentation conventions.
Review effort: Balanced
Findings: None
What changed in this PR
Adds a Lantern-specific semantic convention for recording selected bandit track names alongside arm IDs.
Changes:
- Adds
BanditSelectedTracksKeyasbandit.selected_tracks. - Documents index alignment with
BanditSelectedArmsKey.
| File | Description |
|---|---|
custom.go |
Defines and documents the new Bandit telemetry key. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
BanditSelectedTracksKey(bandit.selected_tracks): the track name of each selected arm, index-aligned withbandit.selected_arms.bandit.selected_armsholds arm IDs (r<region>:t<track>), which can't be read as track names in SigNoz without joining against the track table. Recording the names alongside lets the bandit select span be queried by track directly.Consumer: getlantern/lantern-cloud#3501. Part of getlantern/engineering#3702.
The non-whitespace diff is the three added lines; the surrounding realignment is
gofmt, since the new doc comment splits the const block's alignment group.🤖 Generated with Claude Code