crash: add crash keys and re-export code location and exception keys

[myleshorton]

What

Adds the keys for lantern-box crash reports (getlantern/lantern-box#343):

Re-exported from OTel semconv v1.34.0 (standard.go):

• CodeFunctionNameKey (code.function.name)
• CodeFilePathKey (code.file.path)
• CodeLineNumberKey (code.line.number)
• ExceptionMessageKey (exception.message)

Custom (custom.go, new "Process crashes" group):

• CrashTypeKey (crash.type). lantern-box already emits this, currently as a hardcoded string.
• CrashSignatureKey (crash.signature) holds the panic line with numbers normalised, plus the crashing function. The same bug then groups as one row even when the slice bounds or addresses differ.

Why

When lantern-box restarts it reports the Go crash dump from the previous run. Today the only attribute is crash.type, so crashes can't be grouped or alerted on per bug. lantern-box#343 parses the dump into these attributes. Following the rules in AGENTS.md, it uses the standard code.* and exception.* keys wherever OTel defines one. Only the two concepts OTel lacks are custom.

exception.type is deliberately left out. OTel defines it as the exception's dynamic type (e.g. runtime.boundsError), which a Go crash dump doesn't print.

Pre-PR review (local Codex gate)

• Rounds: 1. Final: CODEX GATE: verdict=approve critical=0 important=0 minor=0
• Exit: approve
• Fixed: none
• Dismissed: none

🤖 Generated with Claude Code

https://claude.ai/code/session_01AECMJ3ddHpHNv9TsAZEndh

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: f4db5679-6cde-443b-9b54-39f3067e0c50

📥 Commits

Reviewing files that changed from the base of the PR and between 90d475a and 3156e30.

📒 Files selected for processing (2)

• custom.go
• standard.go

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The package adds exported attribute keys for Go runtime crash classification and signatures, and re-exports OpenTelemetry code-location and exception attributes.

Changes

Attribute key exports

Layer / File(s)	Summary
Add attribute key exports custom.go, standard.go	custom.go adds CrashTypeKey and CrashSignatureKey. standard.go re-exports code function name, file path, line number, exception type, and exception message attributes.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: jay-418

Merge Risk: ⚪ Minimal · up to 3156e

The added exports match their documented crash and OpenTelemetry attribute contracts. No concrete merge-blocking behavior is indicated, so the change is ready to merge.

Security Architecture Review

Security architecture risk: ⚪ Minimal · up to 3156e

The changes add attribute-name constants without adding crash collection, data export, executable entrypoints, or privileges. No material security risk is introduced by these declarations. Privacy and access controls for downstream crash reporting remain outside this change.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The directly demonstrated change is confined to the package’s exported naming contract. The constants themselves do not increase tenant, service, data-store, or environment access; downstream exposure depends on producers and exporters not assessed here.

Trust Boundaries and Controls

• observed — The added declarations accept no inputs and perform no authorization, execution, or export. They neither introduce a trust-boundary crossing nor supply controls for handling crash values downstream.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main changes: adding crash keys and re-exporting code-location and exception keys.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Copilot review overview

🟡 Changes recommended

The ExceptionTypeKey documentation recommends values that conflict with its OTel semantics.

Review effort: Balanced
Findings: 1

Open (1)

• Avoid using crash classifications as exception.type values · New

What changed in this PR

Adds canonical semantic-convention keys for structured crash reporting and grouping.

Changes:

• Re-exports OTel code-location and exception keys.
• Adds Lantern-specific crash type and signature keys.

File	Description
standard.go	Re-exports standard code and exception attributes.
custom.go	Defines custom crash attributes.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🟢 Approval recommended

The additions follow established semantic-convention structure and satisfy the linked crash-reporting requirements.

Review effort: Balanced
Findings: None

Resolved since last review (1)

• Avoid using crash classifications as exception.type values