Repository navigation
docs(blocks): document preview live embedding - #167
Merged
Merged
Conversation
Co-Authored-By: ChatGPT <noreply@openai.com>
Describe conditional framing checks and header request failures accurately. Document legacy initial-frame timeout behavior and click readiness waits. Co-Authored-By: ChatGPT <noreply@openai.com>
Document window framing, visible activation, and static narrow-screen behavior. Clarify defaults, readiness timing, open-link priority, and producer examples. Co-authored-by: Codex <noreply@openai.com>
Explain compact chrome, reduced margins, and the scroll fallback. Keep the 24px target conditional on the geometry fitting available height. Co-authored-by: Codex <noreply@openai.com>
Document opt-in theme coordination, state feedback, and frame styling. Clarify guarded navigation and local examples for the preview block. Co-authored-by: Codex <noreply@openai.com>
Document the applied-false signal on pagehide and new document startup. Require fresh readiness and theme acknowledgement before revealing the frame. Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <codex@openai.com>
…docs-preview-live-embed
The preview page linked the producer example pages on main, which can move after the release. Point them at the v2.13.0 tag.
Point the device-views example at the Wikipedia page that the module's frame-src already covers, so a consuming docs site renders the live iframe instead of the fallback alert. Correct claims against mod-blocks v2.13.0 and Hinode v3.46.1: default markup gains data attributes and a hidden unavailable block; a timed-out frame is hidden and inert; Hinode ships only the before-change event, so selector management is guidance for a cooperating child; HEAD falls back to GET on any error; frame-ancestors overrides X-Frame-Options; mobile_static falls back to image; the readiness example also sets theme_message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Correct claims against mod-blocks v2.13.0 and Hinode v3.46.1: GET is retried only when HEAD returns an error, and a HEAD 404 leaves the headers unchecked; a window alert has no link; mode posters need both -light and -dark files; padding: 0 removes padding on both axes. Note that the before-change event needs Hinode v3.45.0 or later, and point the restated build-time check at Embedding restrictions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
markdumay
enabled auto-merge
October 29, 2026 13:17
Contributor
Author
|
🎉 This PR is included in version 1.16.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the
previewextensions released ingethinode/mod-blocksv2.13.0. They cover device views and controls, click activation and posters, item tabs, the runtime fallback and open links, opt-in readiness (ready_message), parent-driven theme synchronization (theme_message), the window frame with visible activation, and narrow-screen static previews.Changes
content/blocks/preview.md: the new arguments, defaults and behavior.Validation
pnpm buildandpnpm lintboth pass.Refs gethinode/hinode#2268
🤖 Generated with Claude Code