Repository navigation
feat(nav): add panelDropdown theme icon - #2296
Merged
Merged
Conversation
Responsive nav and table filter dropdowns always drew the stylesheet's caret, even on sites that replace the navbar's caret with an icon. An optional `panelDropdown` theme icon now replaces it. Unset, it falls back to `navbarDropdown`, so a site naming only that icon gets matching indicators throughout. With neither set, the markup is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for gethinode-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
Author
|
🎉 This PR is included in version 3.48.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Responsive nav and table filter dropdowns always draw the stylesheet's caret, even on sites that replace the navbar's caret through the
navbarDropdowntheme icon. A site with a custom navbar icon therefore shows two different dropdown indicators.This adds an optional
panelDropdowntheme icon forassets/panel-dropdown.html:dropdown-toggle-iconmodifier as the navbar.navbarDropdown, so a site naming only that icon gets matching indicators throughout.assets/nav.htmlandassets/table.htmlnow passpageto the partial, which the icon needs.The fallback means sites that already set
navbarDropdownwill see the icon on these dropdowns after upgrading.Testing
test:templatespasses in the default,theme-iconsandmenu-caseenvironmentstheme-iconsoverlay now sets both icons, and the two nav class checks follow the environmentpanelDropdownremoved from the overlay, the toggle renders thenavbarDropdownicon. This is not covered by an automated test🤖 Generated with Claude Code