Repository navigation
fix(sidebar): collapse external-link cue with the item label - #2286
Merged
Merged
Conversation
In a collapsible sidebar, assets/link.html appended the external-link cue after the label span as a bare " <svg>", so it stayed visible beside the item icon in icon-only mode. Render the cue inside .sidebar-item-label instead and pass cue=false to the link partial, so the cue collapses and fades with the label. Expanded rendering is unchanged and the site's externalLinks.cue setting is still honoured. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for gethinode-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
Author
|
🎉 This PR is included in version 3.46.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a collapsible sidebar, assets/link.html appended the external-link cue after the label span as a bare " ", so it stayed visible beside the item icon in icon-only mode. Render the cue inside .sidebar-item-label instead and pass cue=false to the link partial, so the cue collapses and fades with the label. Expanded rendering is unchanged and the site's externalLinks.cue setting is still honoured.