Repository navigation
feat(color): add cancellable theme changes - #2283
Merged
Merged
Conversation
Keep internal navigation in the current tab unless tab=true is supplied. Preserve external defaults and cues, with opener protection for new tabs. Cover direct buttons and responsive link groups with rendered regressions. Co-Authored-By: ChatGPT <noreply@openai.com>
Forward the menu's original tab value so only explicit internal choices open new tabs while external links continue to inherit the configured default. Exercise navbar buttons, direct buttons, and responsive links under both external defaults. Check cues on each anchor and remove the inactive GetPage mount. Refs: #2275 Co-Authored-By: ChatGPT <noreply@openai.com>
Expose the normalized preference before persistence and theme updates so document listeners can cancel the setter. Cover initialization, system appearance, restored pages, and normal controls. Refs #2280 Co-authored-by: Codex <noreply@openai.com>
Merge the current module updates into the button and color mode fixes.
✅ Deploy Preview for gethinode-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
Author
|
🎉 This PR is included in version 3.45.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Color-mode setters now dispatch a synchronous, cancelable
hinode:color-mode:before-changeevent before updating stored preferences, root theme attributes or selectors. Existing behavior continues when the event is not canceled. The normalized requested preference is available asdetail.theme.Buttons also honor explicit internal new-tab choices, and navbar callers preserve omitted arguments so existing external defaults and cues continue to apply.
Validation: full lint/event/template/strict-image suite, root and multilingual example builds, module verification, and native Chrome/WebKit theme and new-tab controls. Independent finalization review passed, including a partial event-payload mutation that failed in both browsers and passed after exact restoration. Required CI runs on this PR.
Refs #2275, #2280.