Skip to content

Add signals library, restructure panel scripts, and enhance accessibility #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giuscris merged 8 commits into from
Oct 27, 2026
Merged

Add signals library, restructure panel scripts, and enhance accessibility #971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
10e0c98
Add `@preact/signals-core` and enable stricter lint rules in the panel
giuscris Oct 24, 2026
92d5741
Restructure the panel scripts and derive their state with signals
giuscris Oct 24, 2026
3c12a62
Remove the `requestSubmit()` polyfill from the panel
giuscris Oct 24, 2026
289df12
Add keyboard navigation to the dropdown menus of the panel
giuscris Oct 24, 2026
813bdfe
Fix the keyboard, focus and overlay issues of the panel
giuscris Oct 24, 2026
1f75239
Make the actions of the form inputs buttons and label the search inputs
giuscris Oct 24, 2026
0447f23
Keep the seconds in the value of the date input
giuscris Oct 24, 2026
b35b879
Fix the calendar year navigation, the weekday names and the date rese…
giuscris Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions panel/biome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "https://biomejs.dev/schemas/2.5.15/schema.json",
"$schema": "https://biomejs.dev/schemas/2.6.2/schema.json",
"vcs": {
"enabled": false,
"clientKind": "git",
Expand Down Expand Up @@ -31,13 +31,17 @@
"noArguments": "error",
"noExtraBooleanCast": "error",
"noUselessCatch": "error",
"noUselessCatchBinding": "error",
"noUselessTernary": "error",
"noUselessEscapeInRegex": "error",
"noUselessTypeConstraint": "error"
},
"correctness": {
"noInvalidUseBeforeDeclaration": "error",
"noPrecisionLoss": "error",
"noUndeclaredVariables": "error",
"noUnusedLabels": "error",
"noUnusedPrivateClassMembers": "error",
"noUnusedVariables": "error"
},
"style": {
Expand All @@ -54,21 +58,30 @@
"useSpreadOverApply": "error",
"useTemplate": "error"
},
"nursery": {
"noFloatingPromises": "error",
"noUnmodifiedLoopCondition": "error"
},
"suspicious": {
"noCatchAssign": "error",
"noConsole": "warn",
"noConstantBinaryExpressions": "error",
"noDoubleEquals": "error",
"noDuplicateEnumValues": "error",
"noEmptyBlockStatements": "error",
"noExplicitAny": "off",
"noFallthroughSwitchClause": "error",
"noExtraNonNullAssertion": "error",
"noImportCycles": "error",
"noIrregularWhitespace": "error",
"noPrototypeBuiltins": "error",
"noReturnAssign": "error",
"noSelfCompare": "error",
"noUnassignedVariables": "error",
"noUnusedExpressions": "error",
"noUselessRegexBackrefs": "error",
"noVar": "error",
"useAwait": "error"
"useAwait": "error",
"noLoopFunc": "error"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion panel/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import * as esbuild from "esbuild";
const watch = process.argv.includes("--watch");

const options = {
entryPoints: { "app.min": "./src/ts/app.ts" },
entryPoints: { "app.min": "./src/ts/index.ts" },
bundle: true,
format: "esm",
target: "es2020",
Expand Down
3 changes: 2 additions & 1 deletion panel/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
"@codemirror/state": "^6.7.6",
"@codemirror/view": "^6.43.14",
"@lezer/highlight": "^1.2.5",
"@preact/signals-core": "^1.14.4",
"chartist": "^1.5.0",
"prosemirror-commands": "^1.7.2",
"prosemirror-history": "^1.5.1",
Expand All @@ -51,7 +52,7 @@
"sortablejs": "^1.15.7"
},
"devDependencies": {
"@biomejs/biome": "2.5.15",
"@biomejs/biome": "^2.6.2",
"@types/sortablejs": "^1.15.9",
"esbuild": "^0.28.2",
"postcss": "^8.5.30",
Expand Down
102 changes: 65 additions & 37 deletions panel/pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions panel/src/scss/components/_modals.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@
display: flex;
}

body:has(.modal.open) {
overflow: hidden;
}

.modal-header,
.modal-content,
.modal-footer {
Expand Down
3 changes: 3 additions & 0 deletions panel/src/scss/components/_sidebar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@

body:has(.sidebar.show) {
overflow: hidden;
@media (min-width: #{map.get($breakpoints, "md")}) {
overflow: visible;
}
}

.sidebar-wrapper {
Expand Down
21 changes: 18 additions & 3 deletions panel/src/scss/components/forms/_forms-base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,15 +151,30 @@
.form-input-action {
position: absolute;
top: 50%;
right: 0.5rem;
right: 0.25rem;
padding: 0 0.25rem;
border: 0;
border-radius: var(--border-radius);
background: none;
color: var(--color-base-100);
cursor: pointer;
font: inherit;
line-height: inherit;
transform: translateY(-50%);
transition: color var(--transition-time-sm);

&:hover {
color: var(--color-accent-500);
}

&:focus {
outline: none;
}

&:focus-visible {
@include focusring;
}

.form-input:disabled + &,
.form-input:read-only + &,
.form-input:placeholder-shown + &,
Expand All @@ -179,11 +194,11 @@
}

.form-input-wrap .form-input-icon + .form-input {
padding-left: 1.75rem;
padding-left: 1.875rem;
}

.form-input-wrap .form-input:has(+ .form-input-action) {
padding-right: 1.625rem;
padding-right: 1.875rem;
}

.form-input-description {
Expand Down
Loading
Loading