Repository navigation
Find CJK words inside post titles and descriptions - #1767
Open
jayhemnani9910 wants to merge 1 commit into
Open
jayhemnani9910 wants to merge 1 commit into
jayhemnani9910 wants to merge 1 commit into
Conversation
Postgres has no CJK parser, so a run of Chinese was one lexeme and only a prefix of the whole run matched. Fixes getfider#1766
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: Fixes #1766
Searching for
中文didn't find a post titled有中文路径下无法使用. Postgres has no CJK parser, so a run of Chinese is a single lexeme and only a prefix of the whole run matched.When a search word has Han, Kana or Hangul characters, it now also matches with
ILIKE '%word%'on the title and description. Searches without CJK characters run the same query as before.The new test fails without the change, and
go test ./app/services/sqlstore/postgres/passes on Postgres 17.ILIKE '%word%'can't use the search index, so a CJK query on a very large board scans its posts.Checklist