Repository navigation
Clamp cart amount when variant changes to respect sellable quantity - #682
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ENqaKMvnNmmmqsbqBo4MJr
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a menu item variant is changed, the cart amount is now automatically clamped to the new variant's sellable quantity if the current amount exceeds it. This prevents users from adding more items than available for the newly selected variant.
Changes
clampAmountToVarianthelper function that respects a variant'ssellableQuantityand ensures a minimum of 1SELECT_OPTION_VALUEaction, in addition to the existing clamping onCHANGE_AMOUNTImplementation Details
The
clampAmountToVariantfunction centralizes the clamping logic: it caps the amount to the variant'ssellableQuantity(if the variant is sellable) and enforces a minimum of 1. This same logic now applies both when the user manually changes the amount and when the variant selection changes.https://claude.ai/code/session_01ENqaKMvnNmmmqsbqBo4MJr