Repository navigation
feat: add UpdateMachine method to Driver interface for in-place node updates - #1191
valeryia-hurynovich wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @valeryia-hurynovich! |
|
Hi @valeryia-hurynovich. Thanks for your PR. I'm waiting for a gardener member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…updates Extend the Driver interface with an UpdateMachine method that providers can implement to update underlying infrastructure resources (e.g. a ServerClaim image) after a successful in-place node OS update. MCM transfers Machine ownership to a new MachineSet after in-place update completes, patching Machine.spec.class.name to the new MachineClass. However, no existing driver method is called at that point, so providers have no hook to react to the MachineClass change. The new UpdateMachine method fills this gap: - Called from reconcileClusterMachine (triggerUpdateFlow) when the Machine carries the LabelKeyNodeUpdateResult=successful label that the deployment controller sets during ownership transfer. - Receives the Machine and the already-resolved new MachineClass. - Providers that do not support in-place VM updates should return codes.Unimplemented; triggerUpdateFlow handles this gracefully. - FakeDriver returns codes.Unimplemented (safe default for existing providers). Signed-off-by: valeryia-hurynovich <v.hurynovich@sap.com>
30a1121 to
13d47be
Compare
What this PR does / why we need it:
Extend the Driver interface with an UpdateMachine method that providers can implement to update underlying infrastructure resources (e.g. a ServerClaim image) after a successful in-place node OS update.
MCM transfers Machine ownership to a new MachineSet after in-place update completes, patching Machine.spec.class.name to the new MachineClass. However, no existing driver method is called at that point, so providers have no hook to react to the MachineClass change.
The new UpdateMachine method fills this gap:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This PR extends the Driver interface with an UpdateMachine method to allow providers to update underlying infrastructure resources after a successful in-place node OS update.
Release note: