Repository navigation
Conversation
…erveValue annotation Signed-off-by: Gagan163264 <gagan.surathkal@gmail.com>
Signed-off-by: Gagan163264 <gagan.surathkal@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Gagan163264 <gagan.surathkal@gmail.com>
gagan16k
marked this pull request as draft
November 12, 2026 10:11
Signed-off-by: Gagan163264 <gagan.surathkal@gmail.com>
…nnotations Signed-off-by: Gagan163264 <gagan.surathkal@gmail.com>
Signed-off-by: Gagan163264 <gagan.surathkal@gmail.com>
Signed-off-by: Gagan163264 <gagan.surathkal@gmail.com>
Signed-off-by: Gagan163264 <gagan.surathkal@gmail.com>
Signed-off-by: Gagan163264 <gagan.surathkal@gmail.com>
…eservation Signed-off-by: Gagan163264 <gagan.surathkal@gmail.com>
Signed-off-by: Gagan163264 <gagan.surathkal@gmail.com>
Signed-off-by: Gagan163264 <gagan.surathkal@gmail.com>
Signed-off-by: Gagan163264 <gagan.surathkal@gmail.com>
Signed-off-by: Gagan163264 <gagan.surathkal@gmail.com>
gagan16k
marked this pull request as ready for review
November 14, 2026 05:55
Member
Author
|
/kind bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
node.machine.sapcloud.io/preserveannotation behaviourFollowing design changes in following the design in #1171, the node is now the single source of truth for the preserve annotation.
Removal of the preserve annotation is now a no-op: to stop preservation a user must set
preserve=falseexplicitly.Other changes as part of this:
node.machine.sapcloud.io/last-applied-node-preserve-valueannotation is also dropped entirely, as it is no longer needed.PreservationAction enum + determinePreservationAction
This PR extracts preservation decision logic into a pure function
determinePreservationAction()returning one of four values:None,Preserve,StopKeepAnnotation,StopRemoveAnnotation.manageMachinePreservation()now dispatches on these set of states.Based on comment by @elankath.
MachineSet controller solely responsible for
PreserveExpiryTime-expiry deletionsWith the PR, the machine controller returns
PreservationActionNoneforFailed+expiredmachines, leaving themachineSetcontroller as the sole actor responsible for their deletion.This also prevents the re-preservation loop: previously, the
MachineControllerremoved the annotation and PET, but themachineSetwouldn't delete the machine yet, it would see a Failed machine with no annotation+no PET and potentially re-preserve it.stopAutoPreservationForMachinesdeletes viaterminateMachinesNow
stopAutoPreservationForMachinescallsterminateMachines()after removing the annotation, so unpreserved machines are immediately queued for deletion.This is so that when the
autoPreserveFailedMachineMaxis reduced and excess auto-preserved machines need to be unpreserved, they do not stay preserved until their PET expires.Some other smaller changes:
DeferCleanup()removed from IT, as it races withAfterAll()MCD deletion - runmanageAutoPreservationOfFailedMachines()andstopAutoPreservationForMachines()setFailedState()helperWhich issue(s) this PR fixes:
Fixes #1171
Release note: