fix(resource): white nui screen and missing manifest web files - #90
Merged
Maximus7474 merged 2 commits intoSep 30, 2026
Merged
Maximus7474 merged 2 commits into
Maximus7474 merged 2 commits into
Conversation
The dark class sits on #root, so body got the light theme's white background and covered the whole game screen in-game.
The fxmanifest files list was built before vite wrote dist/web, so a clean build shipped a ui_page with none of its files and later builds listed the previous build's output.
Maximus7474
approved these changes
Sep 30, 2026
Maximus7474
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR, the feature branch was still considered as in a prototype state pending the beginning of the full implementation of the resource. UI layout was still up for discussion which meant that we weren't interested in fine tuning bugs/issues with fivem's CEF and the web app.
Maximus7474
merged commit Sep 30, 2026
9bc913e
into
fxManagerProject:feat/in-game-menu
3 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #36. Two small fixes found while running
feat/in-game-menuon a live server:bodygot the light theme's whitebg-background, because.darkis set on#rootand not onbody. In game, that made the NUI page a solid white sheet over the whole game screen. The body is now transparent.scripts/build.jslisteddist/webfor the fxmanifest beforevite buildhad written it. A clean build therefore shipped aui_pagewithout its files, and later builds listed the previous build's files. Vite now runs before the file list is built.Generative AI Disclosure
Note
Be honest—using GenAI does not penalize your PR, but failing to declare its use may result in the PR not being considered.
(If yes, please briefly describe what tools were used and for what purpose below):
Tests
Additional Notes
feat/in-game-menu, since both files only exist there.dist/webfile in the fxmanifest.bun run typecheckpasses, but it doesn't includeapps/resource. Neither change is TypeScript.