Skip to content

fix(resource): white nui screen and missing manifest web files - #90

Merged
Maximus7474 merged 2 commits into
fxManagerProject:feat/in-game-menufrom
xThrasherrr:fix/in-game-menu-nui
Sep 30, 2026
Merged

Maximus7474 merged 2 commits into
fxManagerProject:feat/in-game-menufrom
xThrasherrr:fix/in-game-menu-nui

Conversation

@xThrasherrr

Copy link
Copy Markdown

Description

Part of #36. Two small fixes found while running feat/in-game-menu on a live server:

  • body got the light theme's white bg-background, because .dark is set on #root and not on body. In game, that made the NUI page a solid white sheet over the whole game screen. The body is now transparent.
  • scripts/build.js listed dist/web for the fxmanifest before vite build had written it. A clean build therefore shipped a ui_page without its files, and later builds listed the previous build's files. Vite now runs before the file list is built.

Generative AI Disclosure

Note

Be honest—using GenAI does not penalize your PR, but failing to declare its use may result in the PR not being considered.

  • No, Generative AI was not used in the creation of this PR.
  • Yes, Generative AI was used in the creation of this PR.
    (If yes, please briefly describe what tools were used and for what purpose below):
    • Tools used: Claude Code
    • Purpose / What it was used for: finding and writing both fixes, which I reviewed and tested in game.

Tests

  • Tested in development mode
  • Passes typecheck
  • Builds & runs on Windows
  • Builds & runs on Linux

Additional Notes

  • Targets feat/in-game-menu, since both files only exist there.
  • Tested with a production build of the resource on a Windows FXServer run by fxManager v0.4.0, not in development mode. After the change, the game view is no longer covered, and a single clean build lists every dist/web file in the fxmanifest.
  • bun run typecheck passes, but it doesn't include apps/resource. Neither change is TypeScript.
  • Not tested on Linux. Neither change is platform-specific.

The dark class sits on #root, so body got the light theme's white
background and covered the whole game screen in-game.
The fxmanifest files list was built before vite wrote dist/web, so a clean
build shipped a ui_page with none of its files and later builds listed the
previous build's output.
@Maximus7474 Maximus7474 added breaking change Pull request introduces a breaking change to be considered and removed breaking change Pull request introduces a breaking change to be considered labels Sep 30, 2026

@Maximus7474 Maximus7474 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, the feature branch was still considered as in a prototype state pending the beginning of the full implementation of the resource. UI layout was still up for discussion which meant that we weren't interested in fine tuning bugs/issues with fivem's CEF and the web app.

@Maximus7474
Maximus7474 merged commit 9bc913e into fxManagerProject:feat/in-game-menu Sep 30, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants