Repository navigation
fix(ai-pr-review): stop treating agent rule files as protected paths - #141
Merged
Merged
Conversation
AGENTS.md and CLAUDE.md change often and steer how agents write code, not what ships, so a change to them no longer needs a human by default. Agent hooks and permissions stay protected: they run commands on every machine that opens the project. The review still reads rule files from the base branch, so a PR cannot change the rules it is judged by. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A description edit then adds no run of skipped jobs, which replaced the successful review in the PR's checks list. The trigger still accepts a retarget from callers that subscribe to it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
AGENTS.mdandCLAUDE.mdare edited often (new conventions, layout notes), and every such PR became high risk and waited for a human, even when the rest of the change was routine. They steer how agents write code, not what ships.Changes
The default
protected_pathsno longer listsAGENTS.md,CLAUDE.md,CLAUDE.local.mdor all of.claude/. It keeps.claude/settings*.jsonand.claude/hooks/, because hooks and permissions run commands on every machine that opens the project.Unchanged: the review still replaces the PR's rule files with the base branch copies, so a PR cannot change the rules it is judged by. A caller that wants the old behaviour passes its own
protected_paths.The usage comment also drops
editedfrom the recommendedpull_requesttypes: the review already skipped description edits, but that run of skipped jobs replaced the successful review in the PR checks list. Retargeting still works for callers that subscribe to it, and/reviewcovers the rest.Evidence
actionlintis clean. The new pattern matches.claude/settings.json,.claude/settings.local.json,.claude/hooks/*and.github/*, and does not matchAGENTS.mdor.claude/skills/*.