Repository navigation
fix(review-gate): handle a PR without a review comment on newer jq - #140
Merged
Merged
Conversation
On ubuntu-26.04 runners jq 1.8 makes rtrimstr fail on null, which split returns for an empty body, so the gate failed before the first review. The AI review workflow now uses the nested actions from main while it is tuned; the release script pins them to the release tag. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ubuntu-latestnow runs ubuntu-26.04 with jq 1.8, wherertrimstrfails onnull.review_metapassednullto it when the PR had no review comment yet ("" | split("\n")is[]), so the Review gate job failed withendswith() requires string inputson the first events of every PR.Changes
review_metafalls back to an empty line; a test covers a PR without comments.universal-cloud-ai-pr-review.ymlusesuniversal-review-gateanduniversal-ai-pr-review-publishfrom@mainwhile the review is being tuned, so fixes reach callers on@mainwithout a release.bump-action-refs.shpins them to the release tag as usual.Evidence
batsfor the gate, publish and notify actions passes;actionlintis clean. The failing case was a PR's firstpull_request_targetevent before the bot's comment existed.