Repository navigation
chore(deps): bump go-chi/chi to v5.4.0, drop RealIP - #57
Merged
Merged
Conversation
Clears GHSA-j6qf-3m9c-vwj3. CodeForge does not use the affected ClientIPFromXFF helper (only middleware.RealIP), so this is hygiene, not a security fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chi v5.4.0 deprecates RealIP: it rewrites r.RemoteAddr from X-Forwarded-For / X-Real-IP / True-Client-IP without checking that the request came through a trusted proxy. Nothing in CodeForge reads the client IP (rate limiting is keyed by API token), so the middleware only let clients spoof RemoteAddr. Removing it instead of configuring a trusted-proxy list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
freema
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears Dependabot alert for GHSA-j6qf-3m9c-vwj3 (client IP spoofing in
ClientIPFromXFF). CodeForge never calledClientIPFromXFF.chi v5.4.0 also deprecates
middleware.RealIPas spoofable (it trustsX-Forwarded-For/X-Real-IP/True-Client-IPfrom any peer), which golangci-lint flags (SA1019). Nothing in CodeForge reads the client IP — the rate limiter is keyed by API token — so the middleware is removed rather than replaced with a trusted-proxy configuration.No release needed; this lands with the next one.
🤖 Generated with Claude Code