Repository navigation
fix: prevent text overflow in chapter and module name labels - #1850
Closed
ankitrajchoudhari wants to merge 2 commits into
Closed
ankitrajchoudhari wants to merge 2 commits into
ankitrajchoudhari wants to merge 2 commits into
Conversation
Signed-off-by: Ankit Raj Choudhari <233086850+ankitrajchoudhari@users.noreply.github.com>
Signed-off-by: Ankit Raj Choudhari <233086850+ankitrajchoudhari@users.noreply.github.com>
huyenltnguyen
left a comment
huyenltnguyen
left a comment
Member
There was a problem hiding this comment.
Hi there, thank you for the PR.
Please include a screenshot of the change to help verify that it was tested locally.
Comment on lines
+28
to
+29
| node-version: [26] | ||
| pnpm-version: [12] |
Member
There was a problem hiding this comment.
Please remove these changes. They are not relevant.
huyenltnguyen
added
the
status: waiting update
Member
|
Actually, I don't think this PR addresses the right issue. The linked issue is about text being indented, not overflow. |
Author
|
You're right, thank you for the correction — I misread the issue. It's about the inconsistent indentation and spacing of the description text, not overflow. Apologies for the mix-up. I'll take a proper look at the actual indentation behaviour before proposing anything further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long localized strings (e.g. in the A1 Professional Spanish
Certification) can overflow the chapter and module name Text
widgets, causing misaligned layout on some devices.
Added softWrap, overflow: TextOverflow.ellipsis, and maxLines
to both Text widgets in chapter_view.dart so long names wrap
gracefully instead of overflowing.
Closes #1731