Repository navigation
fix(html-handler): add kbd element display support - #1848
Open
ankitrajchoudhari wants to merge 1 commit into
Open
ankitrajchoudhari wants to merge 1 commit into
ankitrajchoudhari wants to merge 1 commit into
Conversation
Keystrokes in freeCodeCamp curriculum are now represented with <kbd> instead of <code>. This adds a Style entry and a TagExtension for kbd elements so they render as keyboard key indicators with a monospace font, gray background, rounded corners, and a subtle border. Closes freeCodeCamp#1845
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Keystrokes in the freeCodeCamp curriculum are now represented with
<kbd>elements instead of
<code>. The mobile app had no<kbd>handling, sothese elements render without styling.
Ref: freeCodeCamp/freeCodeCamp#69619
Solution
'kbd'todefaultStylesmatching'code'stylingTagExtensionfor'kbd'rendering a keyboard-key visual withgray background, 4px radius, subtle border, and Hack monospace font
Testing
Note: Aware of code freeze (#1841). Happy to keep open until freeze lifts.
Closes #1845