Repository navigation
feat: make datasets and accelerate optional dependencies - #213
Merged
Merged
Conversation
Signed-off-by: Andrea Fasoli <andrea.fasoli@ibm.com>
Signed-off-by: Andrea Fasoli <andrea.fasoli@ibm.com>
Signed-off-by: Andrea Fasoli <andrea.fasoli@ibm.com>
andrea-fasoli
requested review from
BrandonGroth,
chichun-charlie-liu,
kcirred,
nwang-ibm and
tharapalanivel
as code owners
October 7, 2026 22:16
datasets and accelerate optional dependenciesdatasets and accelerate optional dependencies
datasets and accelerate optional dependenciesdatasets and accelerate optional dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version caps
datasetsandacceleratebring (e.g.fsspec<=2026.2.0fromdatasets4.x) is blocking vulnerability updates.Neither package is needed by the
aiu_addons, which is the only part of fms-mo that FMS loads.This PR make these two packages installation optional.
Related issues
Closes #212
Changes
pyproject.toml: moveddatasetsinto a newdataextra andaccelerateinto a newlauncherextra. Both are included inopt,examplesandtest, so the Docker image and CI are unchanged.run_quant.py,dq.py,utils/calib_data.py: ifdatasetsis missing, importing these modules now raises anImportErrorthat says to installfms-model-optimizer[data].README.md: documented the new extras.Breaking change
With a plain
pip install fms-model-optimizer, runningrun_quantor direct quantization now requires the[data]extra.Verification
datasetsandaccelerateare not installed. Allaiu_addonsmodules import, and neither package is loaded afterwards.