Repository navigation
Conversation
arnav-kr
marked this pull request as ready for review
November 22, 2026 09:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Refreshes FMC branding across the navigation, favicon family, install icons, page metadata and Open Graph banner. The full community logo is preserved, with transparent light/dark navigation variants that follow the system theme without reloading, and site descriptions now cover watch faces, apps and firmware. Community and project links point to the FMC organization.
Adds Account → Watch Frame with Watch Pro 2 and Watch 3 Pro artwork and four colors per model. The dialog uses the shared desktop modal and mobile sheet. Selections apply immediately without closing the panel; Automatic restores detected appearance. Frame preferences remain separate from installation compatibility checks.
Adds a frame visibility toggle beside the canvas help button in the watchface editor. Shift+F invokes the same action and is listed in shortcut help. Hiding the artwork preserves the dial size and position, canvas element, watchface data and undo history. The control has an accessible pressed state and works on desktop and mobile.
Reads optional model and factory-color metadata from supported Bluetooth advertisements, with a bounded, read-only
AT GETPIDfallback for the model. Handles fragmented replies, unavailable metadata, conflicting product IDs and device re-selection. Documents the identification formats and evidence boundaries.Bundles Material Symbols locally and prevents icon names appearing while the font loads. Fixes a tab-indicator reactive update loop. Adds regression tests and updates repository documentation and asset-generation scripts.
Validation
GitHub Actions on Linux/Chromium passes on the final revision: 476 tests passed, 1 skipped, across 87 test files. Formatting, lint and type checking also pass.
Focused editor frame and shortcut checks: 17 passed, covering both models at desktop and mobile sizes, button/keyboard toggling and unchanged document state.
Formatting, lint, Svelte/TypeScript checks and production build pass. Lint retains two existing warnings.
Windows/Edge suite: 470 passed, 1 skipped, 2 failed. Both failures reproduce on unchanged upstream: Windows path separators in the typography allowlist, and exact canvas-resampling pixel equality in an editor rotation test.
Watch Pro 2 hardware: connection and appearance workflow checked. Watch 3 Pro identification and appearance are covered by fixtures and browser tests; physical Watch 3 Pro validation is not claimed.
Light/dark theme sweep: checked live theme changes, navigation logo selection, Watch Frame selections and editor frame toggling on desktop and phone. All 9 focused browser tests also pass in light mode.
Compared desktop and mobile layouts, editor rendering, community links, Watch Frame states and generated branding assets. Verified the built Open Graph image matches the source asset.
Visual comparisons
Before screenshots use upstream commit
76f608abccca561c34f793c47e6578db2142f3de. Both versions use matching viewports and fixtures.Watch Frame