Release v0.2.1 - #78
Merged
Merged
Conversation
The inspection form and submission models handed out `createdAt` and its siblings as the raw `Date` from the attribute. A table column bound to `createdAt` therefore rendered a full datetime instance string instead of a date, which is what the inspection forms index shows today. Every other model in this package formats these getters, guarding an unparseable value with `isValidDate` first, so do the same here. The form model also carried a `frequency` attribute. Nothing schedules an inspection from it, and FleetOps has dropped it from the API resource and the console, so it is removed here too.
The inspection form and submission tests still asserted that the camelCase date getters return the raw Date, so they failed once the getters began formatting it, and the null branch of each isValidDate guard was never run, which held coverage below the 100% gate. Assert each getter through assertDateGetters, like the other models: the yyyy-MM-dd HH:mm rendering of a real date, and null for null, undefined and an unparseable Date. Also assert that the form no longer declares frequency.
Bump package.json to 0.2.1 and seed RELEASE.md so the release-tag workflow can validate the version once this branch merges to main.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 116 +2
Lines 2899 2931 +32
Branches 687 698 +11
=========================================
+ Hits 2899 2931 +32
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Format the inspection models' display dates
- Declare credentials on fuel provider connections so the token and auth method verified by Test Connection are included when saving an integration. - Omit null or absent credentials on updates to fetched records, preserving stored write-only tokens unless the operator supplies a replacement. - Expose imported and unmatched summary counts with explicit computed dependencies so integration tables update when their summaries change. - Register fuel-provider-sync-run models and serializers in addon and host namespaces, including date windows, progress, outcomes, errors and metadata. - Add regression coverage for create/update serialization, write-only save responses, repeated public-ID queries retaining UUID record identity, and deserialization of connection-scoped sync history. Companion data contracts for the Fleet-Ops fuel integration improvements in fleetbase/fleetops@cce089dc, targeting the v0.2.1 release branch. Validation: all 23 focused fuel-provider tests passed; all eight changed JavaScript files passed ESLint, and the staged diff passed whitespace checks.
Exercise lastImported and lastUnmatched for new connections, absent or partial sync summaries, explicit null counts, populated results, and zero unmatched purchases. Verify that replacing a sync result and updating its nested counts both invalidate the cached display values. These two previously untested getters accounted for all CI coverage gaps: two statements, two functions, two lines, and four branch paths. Keep the 100% coverage thresholds, instrumentation, and exclusions unchanged. Validation: 1,051 tests passed. The full coverage gate passes across 147 source files: 2,258/2,258 statements, 1,467/1,467 branches, 727/727 functions, and 2,205/2,205 lines. The changed test also passes ESLint.
…ontracts Fix fuel integration credential persistence and sync history records
…asserting, and send cleared ones as cleared
The work order, maintenance and maintenance schedule serializers read their
polymorphic type with snapshot.attr('<key>_type'), but those models declare no
such attribute, so saving one in a debug build failed with "Model has no
attribute named 'target_type' defined". They now read it through
snapshot.attributes().
Ember Data only calls serializePolymorphicType for a related record that is
present, so removing a target or assignee sent null embedded data while the
_uuid and _type columns kept the old record. Unset relationships are now sent
with both cleared.
Fix work order, maintenance and schedule polymorphic serialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release branch for v0.2.1. Feature PRs targeting this release are retargeted here and merge into this branch; merging this PR into
maintriggers the release-tag workflow, which tagsv0.2.1frompackage.json.Included
Release prep in this branch
package.jsonbumped0.2.0→0.2.1RELEASE.mdseeded with the v0.2.1 header and highlights (placeholders removed so the tag job passes)Update
RELEASE.mdbefore merging if the included set changes.