Conversation
… use token Updated the dismiss_reviews.py script to serve as a no-op security proof of concept. Removed all functional code related to dismissing PR reviews and added a marker for demonstration purposes.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request replaces the utility script scripts/gha/dismiss_reviews.py with a no-op security Proof of Concept (PoC) marker for the Google OSS VRP. The script is now inert, printing a marker message to demonstrate execution within a privileged workflow without utilizing or transmitting the provided token. There are no review comments, and we have no feedback to provide.
|
Evidence captured - closing PoC. Result: run https://github.com/firebase/firebase-cpp-sdk/actions/runs/35316570749 (Checks (secure), event=pull_request_target) executed ALL steps against this fork PR, including "Run actions/checkout" (PR merge ref), "Install prerequisites" and "Dismiss reviews" -- the last one ran the PR-controlled No credentials were read, printed, or transmitted; no API calls were made by the PoC script; no external network access. Full report being submitted to Google OSS VRP (bughunters). POC_ID: VRP-A3-20260918 |
Added a no-op security proof of concept marker script for Google OSS VRP.
docs: sync trigger comment (security PoC bookkeeping)
docs: sync trigger 4
Security research PoC - Google OSS VRP (authorized)
This PR demonstrates that any external contributor can execute
attacker-controlled code inside the privileged
Checks (secure)workflow(
pull_request_target+permissions: write-all), becauseactions/checkoutchecks out the PR merge ref and then runs
scripts/gha/dismiss_reviews.pyfrom the PR with the job token in argv.
What this PR does (non-destructive):
scripts/gha/dismiss_reviews.pywith a no-op marker that printsVRP-A3-MARKER-754219and exits; it does NOT read/print/transmit the tokenand performs no network access.
POC_ID: VRP-A3-20260918
A full report is being submitted to bughunters.google.com. This PR will be
closed immediately after evidence capture.