Skip to content

[chore] Release 9.11.0 Take 2 #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lahirumaramba merged 3 commits into from
Sep 24, 2026
+14 −9
Merged

[chore] Release 9.11.0 Take 2 #1246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e005ec
fix: skip integration tests during release publish
lahirumaramba Sep 24, 2026
7c4155c
chore: publish artifacts to Maven Central before creating release tag
lahirumaramba Sep 24, 2026
fd7b24c
chore: address review feedback on release test skipping
lahirumaramba Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,15 @@ jobs:
id: preflight
run: ./.github/scripts/publish_preflight_check.sh

- name: Publish to Maven Central
run: ./.github/scripts/publish_artifacts.sh
env:
GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }}
GPG_KEY_ID: ${{ secrets.GPG_KEY_ID }}
CENTRAL_USERNAME: ${{ secrets.CENTRAL_USERNAME }}
CENTRAL_TOKEN: ${{ secrets.CENTRAL_TOKEN }}

# See: https://cli.github.com/manual/gh_release_create
- name: Create release tag
env:
Expand All @@ -116,12 +125,3 @@ jobs:
gh release create "$RELEASE_VER" \
--title "Firebase Admin Java SDK $RELEASE_VER" \
--notes "$RELEASE_BODY"

- name: Publish to Maven Central
run: ./.github/scripts/publish_artifacts.sh
env:
GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }}
GPG_KEY_ID: ${{ secrets.GPG_KEY_ID }}
CENTRAL_USERNAME: ${{ secrets.CENTRAL_USERNAME }}
CENTRAL_TOKEN: ${{ secrets.CENTRAL_TOKEN }}
5 changes: 5 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<skipTests>false</skipTests>
<skipUTs>${skipTests}</skipUTs>
<skipITs>${skipTests}</skipITs>

@gemini-code-assist gemini-code-assist Bot Sep 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To avoid passing unresolved property placeholders (like ${skipTests}) when the skipTests property is not explicitly defined on the command line, it is recommended to define a default value for <skipTests> in the <properties> block.

Suggested change
<skipITs>${skipTests}</skipITs>
<skipTests>false</skipTests>
<skipITs>${skipTests}</skipITs>

<netty.version>4.2.18.Final</netty.version>
</properties>

Expand Down Expand Up @@ -146,6 +148,9 @@
</profile>
<profile>
<id>release</id>
<properties>
<skipITs>true</skipITs>
</properties>
<build>
<plugins>
<plugin>
Expand Down
Loading