Skip to content

mount: report unmount failures - #509

Open
anees-r3hman wants to merge 1 commit into
finit-project:masterfrom
anees-r3hman:umount-rc
Open

anees-r3hman wants to merge 1 commit into
finit-project:masterfrom
anees-r3hman:umount-rc

Conversation

@anees-r3hman

Copy link
Copy Markdown

During shutdown, Finit unmounts tmpfs and remaining regular filesystems.
Currently, unmount_regular() has no return value, so shutdown always
reports success for "Unmounting filesystems ...".

On systems with busy or otherwise un-unmountable filesystems, this hides
failures and makes shutdown-related mount issues hard to diagnose.

Return a failure status from unmount_regular() when filesystems remain
mounted, and use it to report the final shutdown unmount result.

Return a failure status from unmount_regular() when filesystems remain
mounted, and use it to report the final shutdown unmount result.

Signed-off-by: Anees Rehman <anees.rehman@atlascopco.com>

@troglobit troglobit left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean, thanks! 👍

Edit: almost forgot, this now only goes onto master for the 5.x series. Let me know if you think this should be backported to 4.x as well.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants