feat(docs): add LaunchBoards banner and README section - #5
Merged
Merged
Conversation
|
Welcome! 👋 Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing! |
This was referenced Sep 26, 2026
lukisch
commented
Sep 26, 2026
lukisch
left a comment
lukisch
left a comment
Collaborator
Author
There was a problem hiding this comment.
Review (merge-reviewer, claude-opus) auf Head 1b92e77: noch nicht gemergt.
- Banner angesehen, neben assets/banner.png: 2400×680 wie das SC-Banner, gleicher Aufbau (Schild links, Titel und Untertitel), blau statt rot, das LB-Schild entspricht assets/LaunchBoards.png. Keine Artefakte, keine Fehltexte. In Ordnung.
- Blockierend, Sprachparität/Anker: In
README.mdersetzt der Diff die Überschrift## Sister-product boundarydurch## LaunchBoards. Der Grenz-Absatz („LaunchBoards shares the implementation but has its own QSettings namespace …“) hängt dadurch ohne eigene Überschrift unter dem neuen Abschnitt. Das TOC in Z. 45 verlinkt aber weiter#sister-product-boundary, der Link ist also tot. DE und ES behalten beide Überschriften (## LaunchBoards+## Schwesterprodukt-Grenzebzw.## Límites de producto hermano). Bitte in EN die Überschrift## Sister-product boundarywieder herstellen, analog zu DE/ES. - Empfehlung: Der Link „LaunchBoards“ zeigt in allen drei Sprachen auf file-bricks/SoftwareCenter. Es gibt aber das öffentliche Pointer-Repo file-bricks/LaunchBoards, auf das auch die Org-Profilseite im Fließtext verweist. Besser dorthin verlinken.
Collaborator
Author
|
Korrektur (merge-reviewer): Die Empfehlung, auf file-bricks/LaunchBoards zu verlinken, ziehe ich zurück (Nutzervorgabe: gleiches Repo wie SoftwareCenter). Offen bleibt nur die EN-Überschrift . |
Generate a LaunchBoards banner (assets/banner-launchboards.png, 2400x680) analogous to the existing SoftwareCenter banner via agy (delegated per policy): same layout/gradient style, blue instead of red, LaunchBoards' own shield icon and "LB" lettering instead of SoftwareCenter's "SC", title "LaunchBoards" and tagline "Organize your workspaces". Add a "LaunchBoards" section with the banner ahead of the existing sister-product-boundary section in README.md, README_de.md and README.es.md (T-20260926-802873568). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PTbvD41MCVmnQWaobvHfCk
Review feedback: the LaunchBoards section had replaced the "Sister-product boundary" heading in README.md (EN) instead of adding alongside it, killing the Quick Navigation anchor and breaking parity with DE/ES (which already had both headings correctly). Restore the heading in README.md, and add a "LaunchBoards" Quick Navigation entry ahead of the existing "Sister-product boundary" / "Schwesterprodukt-Grenze" / "Límites de producto hermano" entry in all three languages. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PTbvD41MCVmnQWaobvHfCk
lukisch
force-pushed
the
feat/T-20260926-802873568-launchboards-banner
branch
from
September 26, 2026 13:07
1b92e77 to
03b2e48
Compare
Collaborator
Author
|
Re-Review (merge-reviewer, claude-opus) auf Head 03b2e48: EN/DE/ES haben jetzt je |
lukisch
added a commit
to file-bricks/.github
that referenced
this pull request
Sep 26, 2026
Adds the LaunchBoards banner (sister product, shared codebase) to the main banner row, linking to the same repo as SoftwareCenter per user instruction. Depends on file-bricks/SoftwareCenter#5 (adds assets/banner-launchboards.png) being merged first, otherwise the image 404s. Claude-Session: https://claude.ai/code/session_01PTbvD41MCVmnQWaobvHfCk Co-authored-by: Lukas Geiger <lukas@um-bruch.org> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
lukisch
added a commit
to file-bricks/LaunchBoards
that referenced
this pull request
Sep 26, 2026
README.md and README_de.md both displayed SoftwareCenter's red "SC" banner mislabeled as "LaunchBoards Banner" (borrowed asset). Repoint both to the new banner-launchboards.png (blue, LaunchBoards shield icon) hosted in the shared SoftwareCenter repository -- same image source as used there, per instruction to keep a single image source. Depends on file-bricks/SoftwareCenter#5 (adds the file) being merged first, otherwise the image 404s. Claude-Session: https://claude.ai/code/session_01PTbvD41MCVmnQWaobvHfCk Co-authored-by: Lukas Geiger <lukas@um-bruch.org> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zusammenfassung
assets/banner-launchboards.png(2400x680), analog zum SoftwareCenter-Banner: blau statt rot, LaunchBoards-Schild-Icon mit "LB" statt "SC", Titel "LaunchBoards", Tagline "Organize your workspaces". Erzeugt via agy (Bildgenerierung an agy delegiert, Ergebnisdatei auf der Platte geprüft, nicht nur der Erfolgsmeldung vertraut).Ticket T-20260926-802873568.
🤖 Generated with Claude Code
https://claude.ai/code/session_01PTbvD41MCVmnQWaobvHfCk