Skip to content

Remove old Jenkins pipeline and test scripts - #1586

Merged
bo3z merged 1 commit into
fastmachinelearning:mainfrom
vloncar:remove-old-ci
Oct 19, 2026
Merged

bo3z merged 1 commit into
fastmachinelearning:mainfrom
vloncar:remove-old-ci

Conversation

@vloncar

@vloncar vloncar commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Description

Removes the old Jenkins test pipeline: the Jenkinsfile, the 13 shell scripts in test/ that it called, and the three model lists those scripts read (test/keras-models.txt, test/onnx-models.txt, test/pytorch-models.txt). Also removes Jenkinsfile from the check-manifest ignore list in pyproject.toml.

The Jenkins pipeline converted the example Keras models with these scripts and built them with Vivado HLS 2019.2 or 2020.1. It no longer runs: pull requests show no Jenkins check, only the GitLab pipeline, the GitHub Actions jobs and pre-commit.ci. All tests now run in the GitLab pipeline. test/pytest/generate_ci_yaml.py creates one job for each group of files in test/pytest, and the synthesis tests and their baselines are part of pytest. The Jenkinsfile was still being updated in dependency changes (#1191, #1518), so removing it also saves that work.

No other file refers to the removed files. Kept: test/board/ (added in #1376) and the example-models submodule, which pytest still uses.

Not in this PR: hls4ml config still sets write_tar=True in hls4ml/cli/__init__.py. Commit 91f8f83 added it for the Jenkins tests. Removing it would change what the command writes, so that can be a separate change if wanted.

Type of change

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (existing configs, APIs or generated code behave differently)
  • New frontend / backend
  • New layer / operator support
  • New configuration option — a new io_type, Strategy, or config attribute
  • Research paper implementation
  • Documentation
  • Build, CI or tooling
  • Refactor / cleanup (no functional change)

Affected areas

Backends: none

Frontends:

  • Not related to a frontend

Components:

  • IR (layers + model graph) / optimizer passes
  • C++ templates / HLS sources under hls4ml/templates/
  • Profiling, reporting or the CLI
  • Packaging, build or CI

Configurations affected and exercised

Backend io_type Strategy Verified
n/a n/a n/a pre-commit, test_agent_docs.py

Tests

No new tests, because this PR only removes files. I ran pre-commit run --hook-stage manual --all-files. All hooks pass except check-manifest. It fails in the same way on main when the git submodules are not checked out, and lists Coyote, ac_types and ac_simutils as missing. test/pytest/test_agent_docs.py passes.

Test configuration (OS, Python, ML framework version, HLS tool version): Linux (EL9), Python 3.11, no HLS tool needed.

AI assistance disclosure

  • None — no AI tool was used.
  • Assisted — completion, refactoring, docstrings, tests; design and code are mine.
  • Substantial — significant AI-generated portions, reviewed and edited by me.
  • Agentic — produced largely end-to-end by an AI agent from my prompts.

Tool(s) and model(s): Claude Code (Claude Opus 5.5)

Where it was used: finding the files the old pipeline used, removing them, and this description.

If anything other than None is ticked, confirm all of the following:

  • I am the author of this contribution and take full responsibility for
    it.
    I have read and understood every line and can explain and defend it
    in review.
  • I verified the generated code against real hls4ml and HLS semantics —
    no invented APIs, config keys, pragmas or citations.
  • All numbers, logs and test results quoted in this PR come from runs I
    actually performed, not from agent output.
  • I have the right to submit this work under the project's licence, and to
    my knowledge it does not reproduce third-party code that would conflict
    with it.
  • No AI tool is credited as an author in any commit in this branch.

Checklist

Required:

  • I have read the contributing guidelines.
  • I installed and ran pre-commit on the files I edited.
  • I added tests under test/pytest covering this change (a bug fix should
    add a test that fails on main and passes here). (Not applicable: files removed only.)
  • I self-reviewed the full diff and it contains no leftover debug code,
    commented-out blocks or unrelated changes.
  • The AI assistance disclosure above is complete and accurate.

If applicable:

  • Documentation under docs/ updated.
  • No new build or synthesis warnings.
  • Public API / config schema changes are documented.

Release note

none

@bo3z bo3z left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bo3z
bo3z merged commit 41f1c31 into fastmachinelearning:main Oct 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants