Repository navigation
Remove old Jenkins pipeline and test scripts - #1586
Merged
Merged
Conversation
23 of 36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the old Jenkins test pipeline: the
Jenkinsfile, the 13 shell scripts intest/that it called, and the three model lists those scripts read (test/keras-models.txt,test/onnx-models.txt,test/pytorch-models.txt). Also removesJenkinsfilefrom the check-manifest ignore list inpyproject.toml.The Jenkins pipeline converted the example Keras models with these scripts and built them with Vivado HLS 2019.2 or 2020.1. It no longer runs: pull requests show no Jenkins check, only the GitLab pipeline, the GitHub Actions jobs and pre-commit.ci. All tests now run in the GitLab pipeline.
test/pytest/generate_ci_yaml.pycreates one job for each group of files intest/pytest, and the synthesis tests and their baselines are part of pytest. TheJenkinsfilewas still being updated in dependency changes (#1191, #1518), so removing it also saves that work.No other file refers to the removed files. Kept:
test/board/(added in #1376) and theexample-modelssubmodule, which pytest still uses.Not in this PR:
hls4ml configstill setswrite_tar=Trueinhls4ml/cli/__init__.py. Commit 91f8f83 added it for the Jenkins tests. Removing it would change what the command writes, so that can be a separate change if wanted.Type of change
io_type, Strategy, or config attributeAffected areas
Backends: none
Frontends:
Components:
hls4ml/templates/Configurations affected and exercised
io_typetest_agent_docs.pyTests
No new tests, because this PR only removes files. I ran
pre-commit run --hook-stage manual --all-files. All hooks pass except check-manifest. It fails in the same way onmainwhen the git submodules are not checked out, and lists Coyote, ac_types and ac_simutils as missing.test/pytest/test_agent_docs.pypasses.Test configuration (OS, Python, ML framework version, HLS tool version): Linux (EL9), Python 3.11, no HLS tool needed.
AI assistance disclosure
Tool(s) and model(s): Claude Code (Claude Opus 5.5)
Where it was used: finding the files the old pipeline used, removing them, and this description.
If anything other than None is ticked, confirm all of the following:
it. I have read and understood every line and can explain and defend it
in review.
no invented APIs, config keys, pragmas or citations.
actually performed, not from agent output.
my knowledge it does not reproduce third-party code that would conflict
with it.
Checklist
Required:
pre-commiton the files I edited.test/pytestcovering this change (a bug fix shouldadd a test that fails on
mainand passes here). (Not applicable: files removed only.)commented-out blocks or unrelated changes.
If applicable:
docs/updated.Release note