Conversation
Member
Author
|
This pull request depends on fastly/go-fastly#851 and fastly/go-fastly#853. |
philippschulte
force-pushed
the
pschulte/cdtool-1699_log-explorer-insights-cli
branch
from
August 24, 2026 21:07
0aa1998 to
c910597
Compare
philippschulte
marked this pull request as ready for review
August 24, 2026 21:33
philippschulte
requested review from
jedisct1,
kpfleming and
rcaril
and removed request for
jedisct1
August 24, 2026 21:33
kpfleming
previously requested changes
Aug 25, 2026
kpfleming
left a comment
kpfleming
left a comment
Member
There was a problem hiding this comment.
Overall this looks good, but I've requested some changes for consistency with other commands in the CLI.
…an flag Addresses PR review feedback: the flag took a string [true, false] value. Switched to a bare --domain-exact-match flag matching the CLI proposal spec.
Addresses PR review feedback: users shouldn't have to extract cursor values from output and pass them to subsequent commands. Drop --limit and --cursor and instead loop internally, requesting the max page size and following next_cursor until exhausted, so a single invocation returns the full result set bounded by --start/--end/--filter.
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
Adds
fastly service logging log-explorerandfastly service logging insightscommands with service scoping, filtering, pagination, visualization options, JSON/human-readable output, and test coverage.All Submissions:
New Feature Submissions: