Skip to content

Suppress type errors for Pyre upgrade (landing group 36) - #5299

Open
maggiemoss wants to merge 1 commit into
facebook:mainfrom
maggiemoss:export-D125460342
Open

maggiemoss wants to merge 1 commit into
facebook:mainfrom
maggiemoss:export-D125460342

Conversation

@maggiemoss

@maggiemoss maggiemoss commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Summary:
X-link: https://github.com/meta-recsys/recir/pull/463

X-link: meta-pytorch/torchrec#4889

X-link: meta-pytorch/torchft#370

X-link: meta-pytorch/captum#1941

X-link: meta-pytorch/MSLK#554

X-link: facebookincubator/MCGrad#349

This diff was automatically generated by the Pyre per-target upgrade tool.

It adds # pyrefly: ignore comments for type errors that an upcoming Pyrefly version will report. It changes comments only; it does not change Python runtime behavior.

Landing group: e969e1002540802bac99534f197c9484caa207469bb40dafcb1a557f726e826d (attempt 1, 19 batches, 145 files)
Merged patch SHA-256: 69696c785aa6060a84f0089cc1d3583d6c0ec2da15ba68ffd3e0f9e4abb1b16d

Fresh isolated full worker and Autoland validation with sharded discovery and idempotent batch writes

#pyreupgrade

Differential Revision: D125460342

@meta-cla meta-cla Bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 15, 2026
@meta-codesync

meta-codesync Bot commented Oct 15, 2026

Copy link
Copy Markdown

@maggiemoss has exported this pull request. If you are a Meta employee, you can view the originating Diff in D125460342.

@codecov-commenter

codecov-commenter commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.59%. Comparing base (f4e58e0) to head (cf8d52b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5299   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files         621      621           
  Lines       70966    70966           
=======================================
  Hits        68550    68550           
  Misses       2416     2416           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Summary:
X-link: https://github.com/meta-recsys/recir/pull/463

X-link: meta-pytorch/torchrec#4889

X-link: meta-pytorch/torchft#370

X-link: meta-pytorch/captum#1941

X-link: meta-pytorch/MSLK#554

X-link: facebookincubator/MCGrad#349

This diff was automatically generated by the Pyre per-target upgrade tool.

It adds `# pyrefly: ignore` comments for type errors that an upcoming Pyrefly version will report. It changes comments only; it does not change Python runtime behavior.

Landing group: `e969e1002540802bac99534f197c9484caa207469bb40dafcb1a557f726e826d` (attempt 1, 19 batches, 145 files)
Merged patch SHA-256: `69696c785aa6060a84f0089cc1d3583d6c0ec2da15ba68ffd3e0f9e4abb1b16d`

Fresh isolated full worker and Autoland validation with sharded discovery and idempotent batch writes

#pyreupgrade

Differential Revision: D125460342

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants