Repository navigation
Suppress type errors for Pyre upgrade (landing group 4) (#5298) - #5298
Closed
maggiemoss wants to merge 1 commit into
Closed
maggiemoss wants to merge 1 commit into
maggiemoss wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@maggiemoss has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123975487. |
Summary: X-link: pytorch/FBGEMM#6417 X-link: https://github.com/facebookresearch/FBGEMM/pull/3278 This diff was automatically generated by the Pyre per-target upgrade tool. It adds `# pyrefly: ignore` comments for type errors that an upcoming Pyrefly version will report. It changes comments only; it does not change Python runtime behavior. Landing group: `e5cd8bb1932882651ede8b1556fb5d4edfc7db11f903fed396e610d810c715d8` (attempt 1, 20 batches, 54 files) Merged patch SHA-256: `4d1b81b93caadf1bc3a3bdf05e1317ce2186abe77754c5a430539a158db52e59` Full fbcode Pyrefly per-target upgrade using D123902372 typed Buck uquery scheduler; target commit af8bbadc839ed3725786ccbc573c25769d4a144b. #pyreupgrade Differential Revision: D123975487
meta-codesync
Bot
changed the title
maggiemoss
force-pushed
the
export-D123975487
branch
from
October 7, 2026 22:16
821bf58 to
4d98cab
Compare
maggiemoss
pushed a commit
to maggiemoss/FBGEMM
that referenced
this pull request
Oct 7, 2026
Summary: X-link: https://github.com/facebookresearch/FBGEMM/pull/3278 X-link: facebook/Ax#5298 This diff was automatically generated by the Pyre per-target upgrade tool. It adds `# pyrefly: ignore` comments for type errors that an upcoming Pyrefly version will report. It changes comments only; it does not change Python runtime behavior. Landing group: `e5cd8bb1932882651ede8b1556fb5d4edfc7db11f903fed396e610d810c715d8` (attempt 1, 20 batches, 54 files) Merged patch SHA-256: `4d1b81b93caadf1bc3a3bdf05e1317ce2186abe77754c5a430539a158db52e59` Full fbcode Pyrefly per-target upgrade using D123902372 typed Buck uquery scheduler; target commit af8bbadc839ed3725786ccbc573c25769d4a144b. #pyreupgrade Differential Revision: D123975487
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5298 +/- ##
=======================================
Coverage 96.59% 96.59%
=======================================
Files 621 621
Lines 70966 70966
=======================================
Hits 68550 68550
Misses 2416 2416 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: pytorch/FBGEMM#6417
X-link: https://github.com/facebookresearch/FBGEMM/pull/3278
This diff was automatically generated by the Pyre per-target upgrade tool.
It adds
# pyrefly: ignorecomments for type errors that an upcoming Pyrefly version will report. It changes comments only; it does not change Python runtime behavior.Landing group:
e5cd8bb1932882651ede8b1556fb5d4edfc7db11f903fed396e610d810c715d8(attempt 1, 20 batches, 54 files)Merged patch SHA-256:
4d1b81b93caadf1bc3a3bdf05e1317ce2186abe77754c5a430539a158db52e59Full fbcode Pyrefly per-target upgrade using D123902372 typed Buck uquery scheduler; target commit af8bbadc839ed3725786ccbc573c25769d4a144b.
#pyreupgrade
Differential Revision: D123975487