Repository navigation
Clarify objective signs in getting started guide - #5284
Closed
saitcakmak wants to merge 1 commit into
Closed
saitcakmak wants to merge 1 commit into
saitcakmak wants to merge 1 commit into
Conversation
Summary: Clarify that objective-expression signs control optimization direction while `raw_data` should contain the original observed metric values. Distinguish the negative sign intrinsic to Hartmann6 from the negative objective sign used to minimize it. Resolves facebook#5283. Differential Revision: D119166605
meta-cla
Bot
added
the
CLA Signed
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119166605. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5284 +/- ##
==========================================
- Coverage 96.57% 96.57% -0.01%
==========================================
Files 621 621
Lines 70911 70911
==========================================
- Hits 68485 68480 -5
- Misses 2426 2431 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in 02c0757. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Clarify that objective-expression signs control optimization direction while
raw_datashould contain the original observed metric values. Distinguish the negative sign intrinsic to Hartmann6 from the negative objective sign used to minimize it.Resolves #5283.
Differential Revision: D119166605