Repository navigation
Conversation
Contributor
Python Type Checking Results (Pyright)
Excluded files with errors (4 files)These files have known type errors and are excluded from CI. Remove from
|
dbrattli
marked this pull request as draft
October 16, 2026 20:23
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Python's Async replacement accepted several F# members without corresponding runtime functions. This adds
Async.Choice,Async.OnCancel, andAsync.StartImmediateAsTask, plus cancellableTask.Delayand directAsync<'T>binding andreturn!intask { }.Compiled
Async.StartChildnow uses a newstart_child_linkedruntime entry point: it starts its child when the outer async runs, links the child's token to the parent, and cancels the underlying child when a timeout expires. The existing Pythonstart_childfunction keeps its published behavior. A timeout still leaves the parent token usable, and a child-raised timeout exception keeps its original identity.Async.Choiceconverts Fable enumerables through the runtime iterator adapter, which also keeps its generated Python type correct. The Python async and task suites exercise the new members and timeout behavior through F# on .NET and generated Python.Python counterpart to #5097.