Skip to content

Print the top of the stack first in submit output #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bortlesboat wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −2
Open

Print the top of the stack first in submit output #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ghstack/submit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2164,14 +2164,14 @@ def format_url(s: DiffMeta) -> str:

if self.short:
# Guarantee that the FIRST PR URL is the top of the stack
print("\n".join(format_url(s) for s in reversed(diffs_to_submit)))
print("\n".join(format_url(s) for s in diffs_to_submit))
return

print()
print("# Summary of changes (ghstack {})".format(ghstack.__version__))
print()
if diffs_to_submit:
for s in reversed(diffs_to_submit):
for s in diffs_to_submit:
url = format_url(s)
print(" - {} {}".format(s.what, url))

Expand Down
15 changes: 15 additions & 0 deletions test/submit/short_stack.py.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
from ghstack.test_prelude import *

await init_test()

await commit("A")
await commit("B")
with captured_output() as (out, err):
await gh_submit("Initial", short=True)
assert_eq(
out.getvalue(),
"https://github.com/pytorch/pytorch/pull/501\n"
"https://github.com/pytorch/pytorch/pull/500\n",
)

ok()
Loading