Skip to content

[docs] Add protected resources page - #4616

Merged
byronkarlen merged 2 commits into
mainfrom
wbk/fix-protected-channel-descriptions
Oct 13, 2026
Merged

byronkarlen merged 2 commits into
mainfrom
wbk/fix-protected-channel-descriptions

Conversation

@byronkarlen

@byronkarlen byronkarlen commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Why

The channel:protect and channel:unprotect descriptions say only admins can publish to a protected channel. Release Managers and Owners can too.

How

Updated both command descriptions.

Test Plan

Ran eas channel:protect --help and eas channel:unprotect --help and checked the new descriptions.

@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.35%. Comparing base (73edec4) to head (5726b6b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4616      +/-   ##
==========================================
+ Coverage   74.35%   74.35%   +0.01%     
==========================================
  Files        1027     1027              
  Lines       50178    50178              
  Branches    10848    10848              
==========================================
+ Hits        37303    37304       +1     
+ Misses      11884    11883       -1     
  Partials      991      991              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@byronkarlen
byronkarlen force-pushed the wbk/fix-protected-channel-descriptions branch from b54d8a0 to 4e1429a Compare October 13, 2026 20:17
@byronkarlen
byronkarlen marked this pull request as ready for review October 13, 2026 20:22
@byronkarlen
byronkarlen requested a review from tchayen October 13, 2026 20:22
@github-actions

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
packages/eas-cli/** @douglowder
packages/eas-cli/src/commands/channel/** @wschurman, @quinlanj

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

@github-actions

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@byronkarlen
byronkarlen merged commit 3b59a74 into main Oct 13, 2026
10 checks passed
@byronkarlen
byronkarlen deleted the wbk/fix-protected-channel-descriptions branch October 13, 2026 22:56
byronkarlen added a commit to expo/expo that referenced this pull request Oct 13, 2026
# Why
We don't yet have docs for protected channels and we should since the
feature has fully shipped. #50308 added
docs for the Release Manager role but it only briefly touches on
protected channels.

# How
- Added a new "Protected resources" page
(`docs/pages/eas/protected-resources.mdx`) under "Reference", after
"Webhooks" in the EAS sidebar. Originally was going to add it under the
"Expo accounts" section, but this seemed like a better home for it.
- Linked to this new page in our roles/account-types section, and audit
logs section
- Will update eas-cli reference in
expo/eas-cli#4616

# Test Plan
<img width="1296" height="869" alt="image"
src="https://github.com/user-attachments/assets/cb8e6e1e-0b67-4b0b-8359-d0de7348a5cd"
/>
<img width="1299" height="870" alt="image"
src="https://github.com/user-attachments/assets/c38394d4-d3c3-4eab-a86a-8f3fc9d43746"
/>


# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
-->

- [ ] I added a changeset and followed [this short
guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants