Skip to content

[Roman Numerals] Approach docs improvements - #4300

Merged
BethanyG merged 3 commits into
exercism:mainfrom
Yrahcaz7:roman-numerals-approach-improvements
Sep 30, 2026
Merged

BethanyG merged 3 commits into
exercism:mainfrom
Yrahcaz7:roman-numerals-approach-improvements

Conversation

@Yrahcaz7

Copy link
Copy Markdown
Contributor

This PR covers all of the remaining audit items listed in #4289 (see issue 4197 for the original discussion). It also adds a few links to the Python docs where relevant.

However, this PR is still a draft because the recursion approach needs more explanation, and the itertools.starmap() approach would likely benefit from reorganization (these two items were not in the original audit list).

@BethanyG

Copy link
Copy Markdown
Member

@Yrahcaz7 - Thank you so much for this!

However, this PR is still a draft because the recursion approach needs more explanation, and the itertools.starmap() approach would likely benefit from reorganization (these two items were not in the original audit list).

Happy to have you add those two things here, if you'd like. We may as well change whatever needs changing, since we are not likely to not this way again soon. 🙂

@Yrahcaz7
Yrahcaz7 marked this pull request as ready for review September 30, 2026 18:05

@BethanyG BethanyG left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@BethanyG
BethanyG merged commit 6105f6d into exercism:main Sep 30, 2026
11 checks passed
@Yrahcaz7
Yrahcaz7 deleted the roman-numerals-approach-improvements branch September 30, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants