Repository navigation
[P3] Remove EVMETRICS_DEBUG / log.Printf from pkg/metrics in favour of zerolog #50
Description
Priority: P3 (refactor) · Effort: S
Problem
pkg/metrics/metrics.go:86 isDebugEnabled() reads EVMETRICS_DEBUG from the environment on every call and writes with stdlib log.Printf, bypassing the zerolog logger and its --verbose level. The verifier already logs the same events.
Proposed fix
Delete the EVMETRICS_DEBUG branches (about −30 lines), or pass a zerolog.Logger into Metrics. Update the README's "Debug Logging" section to point at --verbose.
Pros / Cons
- ✅ One logging system; less code.
⚠️ Anyone relying onEVMETRICS_DEBUG=trueneeds to switch to--verbose.
Activity
auricom commentedon Oct 20, 2026
Status after #57–#59: still valid and unchanged.
isDebugEnabled()still readsEVMETRICS_DEBUGon every call and writes with stdliblog.PrintffromRecordSubmissionAttemptandRecordSubmissionDaHeight, bypassing zerolog and--verbose. The README Debug Logging section still documents both mechanisms (#38), so update it together with the code. #59 added no new users of it.refactor(metrics): remove EVMETRICS_DEBUG and stdlib log.Printf in fa…
Merge subagent: P3 #50 #51 metrics and client cleanups