fix(core): block object injection via unserialize() - #2449
Merged
Seiger merged 1 commit intoSep 9, 2026
Conversation
The page cache and the sys_files_checksum setting were rebuilt with a plain unserialize(), so a single write into assets/cache or into the settings table ran a vendor POP chain on the next request. Both only ever store arrays; allowed_classes => false keeps them that way. A checksum that did not deserialize to an array now falls back to an empty one instead of fataling in array_key_exists(). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WC5LNcxoHHhRMZadXXbbXi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The page cache and the sys_files_checksum setting were rebuilt with a plain unserialize(), so a single write into assets/cache or into the settings table ran a vendor POP chain on the next request. Both only ever store arrays; allowed_classes => false keeps them that way.
A checksum that did not deserialize to an array now falls back to an empty one instead of fataling in array_key_exists().