Repository navigation
Conversation
…ming Audio frame counters (RageSoundReader Read/SetPosition/GetNextSourceFrame, RageSound position maps, RageSound::GetPositionSeconds) were 32-bit int / float. Files longer than ~13.3 hours at 44.1kHz overflow INT_MAX frames, and float seconds quantize badly long before that (f32 ULP is ~7.8ms at 2^17 seconds). - RageSoundReader pipeline: frame counts int -> int64_t - RageSound position reporting: float -> double seconds - RageTimer / SongPosition / TimingData: float -> double time/beat math - Player hit detection: compute music seconds in double so hit offsets on long files are not quantized to the float32 ULP grid (visible as quantization lines in judgment scatterplots); offsets stay float - GameState::UpdateSongPosition takes double Scoring is unchanged (offsets, wife2/3, dance points remain float/int).
poco0317
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audio frame counters were i32 / f32, Files longer than ~13.5 hours would overflow, and graphs would get visible quantization lines after 9 hours
Scoring is unchanged (Didn't fix the marathon accuracy bug).