Repository navigation
Release v2.5.0 - #119
Merged
Merged
Release v2.5.0#119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version and changelog only. No library code, license, or behavior change.
src/si5351.cppandsrc/si5351.hare untouched, so this is safe to merge and then tag.library.propertiesandlibrary.jsonare both2.5.0. The README changelog follows the v2.4.2 release: a new* v2.5.0section above* v2.4.2.Reviewed since tag
v2.4.2(f885fca):init()/reset()loops (same register programming as v2.4.2, smaller default flash) and adds theSI5351_NO_CLK67opt-out.SI5351_NO_VCXOopt-out and changesset_vcxo()fromvoidtouint8_t.Do not tag
3ca004c(merged #118). That commit still says 2.4.2. After this PR is merged, tagv2.5.0on the merge commit intomaster, the same wayv2.4.2is the merge of #115. Suggested release title:v2.5.0. Suggested notes:init()/reset()output loops. On an Uno (arduino-cli 1.5.1, arduino:avr 1.8.6) the minimalinit()+set_freq()sketch is 10,140 bytes for a constant CLK0 (was 10,830) and 10,868 bytes for a runtime clock index (was 11,558)#define SI5351_NO_CLK67before#include <si5351.h>, or-DSI5351_NO_CLK67.set_freq()andset_freq_manual()return 1 for CLK6 and CLK7 and write nothing, andset_ms()writes nothing for those outputs. Thesi5351_clockenumerators stay, andreset()still initializes all eight clock-control registers. About 1 KB less flash on that Uno runtime-clock sketch (9,870 bytes with the sketch define, 9,836 with the compiler flag)SI5351_NO_VCXO, alone or withSI5351_NO_CLK67.set_vcxo()returns 1 and writes nothing, and later PLL updates use the non-VCXO denominator.reset()still clears the VCXO parameter registers. On that same sketch the define saves 440 bytes (10,428) and the compiler flag saves 472 bytes (10,396). Both defines together are 9,390 bytesset_vcxo()returnsuint8_t: 0 when the PLL and VCXO registers are written, 1 when nothing is written (reference not usable, orSI5351_NO_VCXO). Sketches that ignore the return still compile. Without the macro, register writes match v2.4.2Local check before push:
run_v231_checks.sh --src --require-fixedon this tree, OVERALL PASS, including 0 differing runs vs pinned v2.4.2. The pinned source hash ofsi5351.cpp/si5351.his unchanged (0934075c6b6b5daf).library.propertiesreported version 2.5.0.