docs: fix resize and swap examples in README - #95
Merged
Merged
Conversation
Include the required fill value for cvector_resize and the element type for cvector_swap. Match the C++ resize comparison and explain both arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README API table shows two-argument calls to
cvector_resizeandcvector_swap, but both macros require three arguments. Copying either call currently produces a macro argument-count error.Update the resize comparison to
v.resize(count, value)/cvector_resize(v, count, value), and usecvector_swap(v, other, int)for the table's integer vectors. Briefly explain the fill-value and element-type arguments.Validation on Windows with MinGW-w64 GCC 16.2.0:
-std=c89 -pedantic-errors -Wall -Wextra -Werrorand ran assertions for initialization and swapping.unit-tests.c(18 tests passed) andtest.cusing-std=gnu90 -Wall -Wextra -Werror.git diff --checkpassed.CMake/CTest was not run: the local CMake executable exits with Windows status
0xC0000135. The existing test programs were compiled and run directly with GCC.