Skip to content

Waived review findings: Grok verifier cancellation, deployment-key login, chunk decoding, Grok mapping gaps (unscheduled) #290

Open

Description

@ericlitman

This issue records review findings that were not fixed. Under AGENTS.md, it stays unscheduled until one of these failures is seen in real use.

Source: Unfret's review of #284's merged head (0d0c5d5). Each finding's babysit-pr dispose record holds its basis.

  • Cancelling a verifier run does not stop the next Grok session from starting (v1:3314e206, inert). .claude/skills/verify-open-pstack/scripts/grok.ts spawns a session without checking the interruption signal first. After a cancel, at most the remaining Grok case still runs, and setup restoration still happens.
  • The doctor refuses a Grok deployment-key login (v1:48f7322e, fails-loudly). scripts/doctor.ts accepts only a line that starts "You are logged in". It refuses before any install or write.
  • Grok stream chunks are decoded one at a time (v1:a03cfcd2, inert). scripts/grok.ts decodes each chunk on its own, so a multibyte character split across two chunks becomes U+FFFD inside a JSON string. No assertion reads non-ASCII text, and candidate paths on operator hosts are ASCII.
  • Advisory: Grok has no substitutes for the Claude-only run, verify, plugin-dev:skill-development and loop skills (v1:4874a26d). The mapping in plugins/pstack/skills/poteto-mode/references/codex-tools.md does not name any.
  • Advisory: new-file creation on Grok is mapped to search_replace (v1:d7ac19b0). Grok also exposes write. The live grok:setup run created its file without trouble.

Also recorded: the Grok setup live case leaves an empty ~/.grok/rules/ folder after it restores the sheet's absence. That is because the setup snapshot restores files, not the folders setup creates.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions