Skip to content

Fix forward #284: Grok reflect destination, Grok live-gate reach, empty GROK_HOME #285

Closed

Description

@ericlitman

Introduced by: #284

The merged head's Unfret review (0d0c5d5) raised four findings that babysit-pr classed verdict-changing. This issue covers their fix-forward PR.

Acceptance criteria

  1. Reflect has a Grok destination. plugins/pstack/skills/poteto-mode/references/codex-tools.md, section "Reflect skill copies", gains a Grok row. Project: .grok/skills/<skill>/. User: <config-home>/skills/<skill>/. These are Grok's own skill discovery folders (Grok user guide, 08-skills). Finding v1:1c735e4d.

  2. Grok verification reaches Grok's runtime paths. In .claude/skills/verify-open-pstack/scripts/core.ts, GROK_REACH['grok:dispatch'] includes:

    • plugins/pstack/grok-agents/poteto-agent.md and plugins/pstack/grok-agents/comment-sicko.md
    • plugins/pstack/skills/poteto-mode/scripts/runner/types.ts
    • plugins/pstack/skills/poteto-mode/scripts/runner/registry/index.ts
    • plugins/pstack/skills/poteto-mode/scripts/runner/registry/render.ts
    • plugins/pstack/skills/poteto-mode/references/model-catalog.md
    • plugins/pstack/skills/poteto-mode/SKILL.md

    A classification test shows that each path reaches grok:dispatch. Findings v1:1f3cdb66 and v1:ccdebf5c.

  3. An empty GROK_HOME resolves to the default. The fallback is ${GROK_HOME:-$HOME/.grok}, so an empty GROK_HOME means $HOME/.grok. This applies in scripts/isolation.ts (the setup snapshot), scripts/harness.ts (the case config home) and scripts/grok.ts (the session records). A test shows that the snapshot path with GROK_HOME="" is $HOME/.grok/rules/pstack-models.md. Finding v1:21c02ebc.

Not in scope

These were classed inert or fails-loudly, and their dispositions are recorded on #284:

  • cancellation before a Grok spawn;
  • deployment-key login in the doctor;
  • UTF-8 chunk decoding;
  • the two advisories.

Activity

  1. ericlitman commented on Nov 8, 2026

    @ericlitman
    OwnerAuthor

    PR: #286

  2. added a commit that references this issue on Nov 8, 2026
  3. ericlitman commented on Nov 8, 2026

    @ericlitman
    OwnerAuthor

    #285: Fix forward #284

    The issue body is the only kept version.

    1. Reflect gets a Grok destination row. Done as written, in fix(grok): fix forward #284's Grok findings (#285) #286, as documentation only. The verifier has no Grok Reflect recipe.
    2. GROK_REACH['grok:dispatch'] lists the seven paths, and a test checks them. Done in fix(grok): fix forward #284's Grok findings (#285) #286, then done differently in fix(verify): derive Grok live-gate reach from runtime ownership (#287) #288. After the step-back, fix(verify): derive Grok live-gate reach from runtime ownership (#287) #288 deleted GROK_REACH. Every listed path now permits both Grok features, and core.test.ts checks it.
    3. An empty GROK_HOME resolves to the default. Done as written, in fix(grok): fix forward #284's Grok findings (#285) #286.
      • Proved by the grokHome() helper and the isolation.test.ts "empty GROK_HOME" case.
      • grok:setup on e4537f0 ran the helper with GROK_HOME unset, not empty.

    Batch closeout record: https://github.com/mobilyze-llc/docs/blob/main/projects/open-pstack/records/2026-11-08-batch-281/closeout.md (released in v1.21.0: https://github.com/ericlitman/open-pstack/releases/tag/v1.21.0)

  4. added a commit that references this issue on Nov 9, 2026
    e4537f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions