Ship the binary in the runtime image and gate it in CI - #71
Merged
Merged
Conversation
The multi-stage Dockerfile never copied /epmon into the runtime stage, so the documented docker compose path exited immediately. Add the missing COPY, and cover the container path in CI with a build plus a version smoke run (entrypoint form, since ENTRYPOINT carries the config flag). Fixes #67
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes for operators?
Critical fix: the runtime image never contained the binary (
docker compose upexited instantly) — the missingCOPY --from=buildis added. CI now builds the image and smoke-runsversionon every PR, plus validates the compose file, so Docker packaging can't rot silently again. Verified locally end to end: build, version smoke, and a booted container serving/healthz200 + live probe results.Failing-then-passing test
Pre-fix image:
docker run→exec: /epmon: no such file or directory. Post-fix: boots and serves. The new CI job automates exactly this (build + run-version + compose config).Checklist
gofmt -l .clean (no Go changes)Fixes #67