Report build version on /healthz via X-Epmon-Version - #69
Merged
Merged
Conversation
SECURITY.md tells reporters to read the version from /healthz headers, but no such header existed. Additive SetVersion on the API server, wired to the release vars in main; unset means omitted. Fixes #65
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes for operators?
/healthzcarriesX-Epmon-Version(release version from ldflags,devlocally), making the SECURITY.md reporting flow true as written and giving load balancers/curlbuild identity without exec. Additive API only (new setter, header omitted when unset).Failing-then-passing test
New
TestHealthzVersionHeader(present/absent halves): requires the new setter (build-fails on old code); passes with the fix. Package green with-race.Checklist
go build ./... && go vet ./... && go test ./...green with-race(touched packages; full suite at merge)gofmt -l .cleanFixes #65